Skip to content

Remove stray * for linux*-s390x in slim images#2257

Merged
SimenB merged 1 commit intonodejs:mainfrom
orgads:star-s390x
Jul 16, 2025
Merged

Remove stray * for linux*-s390x in slim images#2257
SimenB merged 1 commit intonodejs:mainfrom
orgads:star-s390x

Conversation

@orgads
Copy link
Contributor

@orgads orgads commented Jul 10, 2025

Description

Discovered by Copilot.

Motivation and Context

Testing Details

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@orgads orgads mentioned this pull request Jul 10, 2025
Merged
12 tasks
@orgads
Copy link
Contributor Author

orgads commented Jul 16, 2025

ping

SimenB
SimenB approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimenB SimenB merged commit 37378fe into nodejs:main Jul 16, 2025
8 checks passed
@github-actions
Copy link

github-actions bot commented Jul 16, 2025

Created PR on the official-images repo (docker-library/official-images#19479). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

@nodejs-github-bot nodejs-github-bot mentioned this pull request Jul 16, 2025
Merged
@orgads orgads deleted the star-s390x branch July 16, 2025 15:32
@nschonni
Copy link
Member

nschonni commented Jul 16, 2025

I'm not going to roll this back, but this shouldn't have landed before the Security releases were built out. Also take any advice that Copilot gives with a grain of salt.
I couldn't see why this approach was taken for this particular architecture (which is why I also didn't land the original PR that introduced it), but I'm also not sure if if this might actually start breaking builds because it needed a wildcard match for some s390x quirk

@orgads
Copy link
Contributor Author

orgads commented Jul 16, 2025 •
edited
Loading

Oops, you're right. This should be rolled back.

I just checked now in node source, and there are linux32-s390x and linux64-s390x. Sorry for the mess.

@orgads
Copy link
Contributor Author

orgads commented Jul 16, 2025

PR for revert:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimenB SimenB SimenB approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@orgads @nschonni @SimenB